Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert #16 #18

Open
ulbqb opened this issue Dec 27, 2023 · 2 comments
Open

revert #16 #18

ulbqb opened this issue Dec 27, 2023 · 2 comments

Comments

@ulbqb
Copy link
Member

ulbqb commented Dec 27, 2023

import { HdPath,Slip10RawIndex } from "@cosmjs/amino/node_modules/@cosmjs/crypto";

It is enough to use cosmjs/[email protected].

@170210
Copy link

170210 commented Jan 10, 2024

@ulbqb Yes, but since cosmy-wasmy is already using @cosmjs/amino, which contains cosmjs/crypto, it will trigger a warning if not modified.

@ulbqb
Copy link
Member Author

ulbqb commented Jan 10, 2024

The cause of the warning is to use different versions between our @cosmjs/crypto and @cosmjs/amino's one.

import { HdPath,Slip10RawIndex } from "@cosmjs/amino/node_modules/@cosmjs/crypto"; 

I don't think this is correct usage of package. It is strange to use packages in imported package's node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants