Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected java.lang.ClassCastException when decoding immutable.ArraySeq #588

Closed
plokhotnyuk opened this issue Aug 5, 2022 · 5 comments
Closed
Assignees
Labels
Milestone

Comments

@plokhotnyuk
Copy link

plokhotnyuk commented Aug 5, 2022

Steps to reproduce:

git clone --depth 1 https://github.com/plokhotnyuk/jsoniter-scala
cd jsoniter-scala
git checkout github.com/FasterXML/jackson-module-scala/issues/588
sbt jsoniter-scala-benchmarkJVM/test
@pjfanning
Copy link
Member

@plokhotnyuk thanks for reporting this. I've started #589 and so far the issue is not obvious but appears to affect immutable ArraySeqs but not not mutable ones. I will continue to investigate later today.

@plokhotnyuk
Copy link
Author

plokhotnyuk commented Aug 5, 2022

@pjfanning Thanks for the fast response!

Could it be due to missing of immutable.ArraySeq in factory lists here?
https://github.com/FasterXML/jackson-module-scala/blob/2.14/src/main/scala-2.13/com/fasterxml/jackson/module/scala/deser/SeqDeserializerModule.scala

@pjfanning
Copy link
Member

@plokhotnyuk yes, that looks to be the case - I had just found it when I saw your comment - I should be able to merge the fix soon (barring unforeseen CI failures)

@pjfanning
Copy link
Member

@plokhotnyuk the 2.14.0-SNAPSHOT with the fix is on Sonatype - I've also backported the fix to 2.13.3+7-9efbe43c-SNAPSHOT.

@pjfanning pjfanning added the 2.14 label Aug 5, 2022
@pjfanning pjfanning added 2.13 and removed 2.14 labels Sep 3, 2022
@pjfanning
Copy link
Member

Fix is in the v2.13.4 release

@cowtowncoder cowtowncoder added this to the 2.13.4 milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants