Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.8.0 #270

Closed
cowtowncoder opened this issue Jul 6, 2016 · 13 comments
Closed

Release 2.8.0 #270

cowtowncoder opened this issue Jul 6, 2016 · 13 comments

Comments

@cowtowncoder
Copy link
Member

We need 2.8.0 release now as well.

@gheine
Copy link

gheine commented Jul 11, 2016

+1

1 similar comment
@brettcave
Copy link

+1

@christophercurrie
Copy link
Member

For now, I have released rc1 and rc2 to Maven, but these are unlikely to work with the final release of 2.8.0, due to interactions with the final fix for FasterXML/jackson-databind#1277.

@cowtowncoder
Copy link
Member Author

Ouch. I was worried there might be something with this fix; did not add than in 2.7.x.
Somewhat ironically I think this was actually for Scala performance.

Still, need to figure out what gives; there was one vague report for jackson-databind that I think is similar or same root cause. If worst comes to worst, will just prevent caching.

Reproduction would be great, I'll try to repro with scala module master.

@cowtowncoder
Copy link
Member Author

I filed this:

FasterXML/jackson-databind#1302

and will fix that. What this means is that for Scala module we'll probably just have to wait for 2.8.1.
I also need to ensure that in future I verify every rc and before official release -- in this case this was a late change (... which I end up regretting... ) which unfortunately did not break any other modules.

@christophercurrie
Copy link
Member

Is it the sort of issue that the Scala module could work around and/or defend against? Would be nice to get a 2.8.0 out, even if it meant disabling caching in some manner.

@cowtowncoder
Copy link
Member Author

@christophercurrie I was trying to think of that, but didn't see an obvious place.
If Scala module does/did override TypeFactory, it'd e possible to override

protected JavaType _fromClass(...)

but that's quite a bit of work. And I don't think module replaces TypeFactory.
If it did, however, another simpler way might be to override

LruMap<...> _typeCache

and its putIfAbsent method.

Fwtw, skipping 2.8.0 is unfortunate, but not unheard of. For 2.7 we just have 2.7.2 and later.

@christophercurrie
Copy link
Member

Upgrading to 2.8.1-SNAPSHOT eliminated the issue, so we may as well just wait for the next release.

@cowtowncoder
Copy link
Member Author

Ok. I'll try to go over open issues list and see if there are things I'd like to close off first, but there are enough issues resolved that I'll do 2.8.1 fairly soon (possibly by this weekend; if not, definitely within 2 weeks).

@cowtowncoder
Copy link
Member Author

Soon was bit sooner: I released 2.8.1 today. We should get the the type modifier patch in yet at least. Not sure if other things are pending?

@bryce-anderson
Copy link

Sorry to pester, but is there an ETA on a 2.8.x release?

@cowtowncoder
Copy link
Member Author

Being discussed; 2.8.1 should be releasable now.

@nbauernfeind
Copy link
Member

2.8.1 and 2.8.2 are now released; we're skipping 2.8.0 per the discussion above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants