Support enum avro serialization with default value #391
Conversation
| * | ||
| * @since 2.16 | ||
| */ | ||
| private static final JacksonAnnotationIntrospector JACKSON_ANNOTATION_INTROSPECTOR = new JacksonAnnotationIntrospector(); |
There was a problem hiding this comment.
No, AnnotationIntrospector should be passed from outside; it may be reconfigured by caller.
We should not rely on default instance.
This just means some more plumbing of things to get AnnotationIntrospector passed.
|
Ok, I realized that the avro core dependency upgrade to 1.9.x would be needed to access "enum default" information (both create and get). But this upgrade is not possible since So I am not 100% sure this is actually achievable at this point. I did make couple of changes to PR, but it is unfortunately not in a compilable state. |
|
Ok, changed target to 2.18, merged changes and updated call of deprecated method to non-deprecated. @Sonic-Rage This might be ready for merge, but I think you should have a look. One thing before merging tho: I think I'd need a CLA (https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf) if you didn't send one earlier. |
| @@ -169,4 +172,38 @@ public void testSchemaForUntypedMap() throws Exception | |||
| verifyException(e, "Maps with non-stringable keys are not supported (yet?)"); | |||
| } | |||
| } | |||
|
|
|||
| // Issue 388 Default value for enums with class | |||
| public void testClassEnumWithDefault() throws Exception | |||
There was a problem hiding this comment.
I think this test better belongs to EnumTest class.
EnumTest did not exists at the time of this PR yet.
Fixes #388.