Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android 2.2 compatibility #126

Merged
merged 1 commit into from
Jan 27, 2014
Merged

Fix Android 2.2 compatibility #126

merged 1 commit into from
Jan 27, 2014

Conversation

goncalossilva
Copy link
Contributor

Same as #124, but for the 2.3 branch.

FroYo doesn't support some of Arrays' functions, such as copyOf() and
copyOfRange(). ArraysCompat implements all variants of those methods,
adding FroYo compatibility back
@cowtowncoder
Copy link
Member

Sounds good, will merge soon. Thank you again for the patch!

One formality we need for substantial changes is a Contributor License Agreement, one page document that just states that you wrote the code in question, and that we can distribute it. Empty doc is found from jackson repo:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and typically most contributors just fill in personal part; company part is optional and may be filled if it's part of daytime work and company wants credit for it. Printing copy, scanning signed version works; some have just used an image package to add printed name. All work fine.

So, if you could fill this and email to "info" at "fasterxml.com", that would be perfect. Let me know if you have questions (can email "tatu" at fasterxml.com) regarding CLA.

Apologies for the hassle, but this is one-time thing, so once it is done we can accept any and all contributions for Jackson projects.

cowtowncoder added a commit that referenced this pull request Jan 27, 2014
@cowtowncoder cowtowncoder merged commit 93fc118 into FasterXML:2.3 Jan 27, 2014
cowtowncoder added a commit that referenced this pull request Jan 27, 2014
@barbeau
Copy link

barbeau commented Jan 27, 2014

@goncalossilva Thanks for contributing this to Jackson! Quick note on licensing - from a quick scan, I believe this code is mostly copy/paste from the Android Open-Source Project (AOSP)?

https://android.googlesource.com/platform/libcore/+/android-4.4.1_r1/luni/src/main/java/java/util/Arrays.java

If so, the code should carry the same Apache 2.0 license header as indicated at the top of the above link. @cowtowncoder would also need to make sure that Apache 2.0 is compatible with the Jackson license.

@goncalossilva
Copy link
Contributor Author

@barbeau This code was extracted from an array utility class I carry around (by me, AOSP, Apache, etc). Answering your question: yes, I just checked and this part in particular is all from the AOSP Arrays.java source. If @cowtowncoder determines the license is compatible with Jackson's, then all that's needed is to add the header. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants