Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-22] [TS Migration] Adjust guidelines, both TS and JS markdown files #39118

Closed
mountiny opened this issue Mar 27, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 27, 2024

Follow up issue for TS migration project. Coming from this spreadsheet

Adjust guidelines, both TS and JS markdown files

cc @blazejkustra @fabioh8010

Issue OwnerCurrent Issue Owner: @laurenreidexpensify
@mountiny mountiny self-assigned this Mar 27, 2024
@mountiny mountiny changed the title [TS Migration] Adjust guidelines, both TS and JS markdown files [HOLD TS migration completion] [TS Migration] Adjust guidelines, both TS and JS markdown files Mar 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@mountiny
Copy link
Contributor Author

mountiny commented Apr 7, 2024

On hold

@melvin-bot melvin-bot bot removed the Overdue label Apr 7, 2024
@fabioh8010
Copy link
Contributor

I'm Fábio from Callstack, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2024
@mountiny mountiny changed the title [HOLD TS migration completion] [TS Migration] Adjust guidelines, both TS and JS markdown files [TS Migration] Adjust guidelines, both TS and JS markdown files Apr 16, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2024
@mountiny
Copy link
Contributor Author

Assigned, what are the next steps here?

@fabioh8010
Copy link
Contributor

@mountiny I'm still focused on other TS / Wave stuff, let's wait this one a little more.

@JKobrynski
Copy link
Contributor

I'm Julian from Callstack, an expert agency, and I’d like to work on this issue!

@JKobrynski
Copy link
Contributor

The PR is ready for review!

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor Author

This was merged

@alexpensify
Copy link
Contributor

Thank you, @mountiny, for the update!

@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 15, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels May 15, 2024
@melvin-bot melvin-bot bot changed the title [TS Migration] Adjust guidelines, both TS and JS markdown files [HOLD for payment 2024-05-22] [TS Migration] Adjust guidelines, both TS and JS markdown files May 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2024
Copy link

melvin-bot bot commented May 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fabioh8010] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@alexpensify alexpensify removed their assignment May 17, 2024
@alexpensify alexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label May 17, 2024
Copy link

melvin-bot bot commented May 17, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 17, 2024
@alexpensify
Copy link
Contributor

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

@laurenreidexpensify - While I'm offline, I need help here completing the payment process after this one clears the 7-day period on 2024-05-22. Thanks!

@alexpensify alexpensify added Weekly KSv2 and removed Daily KSv2 labels May 17, 2024
@laurenreidexpensify
Copy link
Contributor

Payment summary:

@mountiny
Copy link
Contributor Author

This can be closed now I believe, thanks for help!

@alexpensify
Copy link
Contributor

Thanks, @laurenreidexpensify, for your help here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants