From 0020c2e420450e04a9c1c1e707e422431be241bd Mon Sep 17 00:00:00 2001
From: Bhargav Dodla <13788369+EXPEbdodla@users.noreply.github.com>
Date: Mon, 14 Oct 2024 10:11:48 -0700
Subject: [PATCH] fix: Adding min required protobuf version (#142)

Co-authored-by: Bhargav Dodla <bdodla@expediagroup.com>
---
 Makefile       | 2 +-
 pyproject.toml | 2 +-
 setup.py       | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index f3a9495c20..2c6a4e0c7e 100644
--- a/Makefile
+++ b/Makefile
@@ -53,7 +53,7 @@ install-python-ci-dependencies-uv-venv:
 	python setup.py build_python_protos --inplace
 
 install-protoc-dependencies:
-	pip install "protobuf<5" "grpcio-tools>=1.56.2,<2" "mypy-protobuf>=3.1"
+	pip install "protobuf>=4.24.0,<5.0.0" "grpcio-tools>=1.56.2,<2" "mypy-protobuf>=3.1"
 
 lock-python-ci-dependencies:
 	uv pip compile --system --no-strip-extras setup.py --extra ci --output-file sdk/python/requirements/py$(PYTHON_VERSION)-ci-requirements.txt
diff --git a/pyproject.toml b/pyproject.toml
index c91608b6ce..ec16f80add 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,6 +1,6 @@
 [build-system]
 requires = [
-  "protobuf<5",
+  "protobuf>=4.24.0,<5.0.0",
   "grpcio-tools>=1.56.2,<2",
   "mypy-protobuf>=3.1",
   "pybindgen==0.22.0",
diff --git a/setup.py b/setup.py
index bae6dc347b..b04ad502d5 100644
--- a/setup.py
+++ b/setup.py
@@ -37,7 +37,7 @@
     "click>=7.0.0,<9.0.0",
     "colorama>=0.3.9,<1",
     "dill~=0.3.0",
-    "protobuf<5",
+    "protobuf>=4.24.0,<5.0.0",
     "Jinja2>=2,<4",
     "jsonschema",
     "mmh3",
@@ -170,7 +170,7 @@
         "virtualenv==20.23.0",
         "cryptography>=35.0,<43",
         "ruff>=0.3.3",
-        "protobuf<5",
+        "protobuf>=4.24.0,<5.0.0",
         "mypy-protobuf>=3.1",
         "grpcio-tools>=1.56.2,<2",
         "grpcio-testing>=1.56.2,<2",
@@ -505,7 +505,7 @@ def run(self):
     setup_requires=[
         # snowflake udf packages refer to conda packages, not pypi libraries. Conda stack is still on protobuf 4
         # So we are adding protobuf<5 as a requirement
-        "protobuf<5",
+        "protobuf>=4.24.0,<5.0.0",
         "grpcio-tools>=1.56.2,<2",
         "mypy-protobuf>=3.1",
         "pybindgen==0.22.0",