Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile errors out if types are defined in separate file. #13

Open
schematis opened this issue Dec 11, 2021 · 1 comment
Open

Makefile errors out if types are defined in separate file. #13

schematis opened this issue Dec 11, 2021 · 1 comment

Comments

@schematis
Copy link

I've been following your guide on evilmartians, but the build process errors out at:

echo "{\"extends\": \"./tsconfig.json\", \"include\": [\"${HANDLER}\"] }" > tsconfig-only-handler.json
npm run build -- --build tsconfig-only-handler.json

After looking into it, it appears that the new json file is not created at all and I'm unsure about how to get it to create.

Node: 16.13.1 (Also doesn't work on 14.x)
SAM CLI: 1.36.0

@schematis schematis changed the title tsconfig-only-handler.json doesn't build in makefile Makefile errors out if types are defined in separate file. Dec 12, 2021
@schematis
Copy link
Author

schematis commented Dec 12, 2021

Ok this is what I believe is the real issue after downloading the template and doing testing to see where it broke.

If I have project specific types defined in a types.d.ts (or similar) file, the makefile will not run the function specific make operations. I moved the types into the relevant file and sam build ran without error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant