Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No window icon #27

Open
MCOfficer opened this issue Jun 18, 2020 · 3 comments
Open

No window icon #27

MCOfficer opened this issue Jun 18, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@MCOfficer
Copy link
Member

MCOfficer commented Jun 18, 2020 •
edited
Loading

ESL2 still does not have a window icon. This probably requires some winit magic, which means it probably requires support from iced.
@MCOfficer MCOfficer added the enhancement New feature or request label Jun 18, 2020
@casperstorm
Copy link

If you target at least rev 5190bcea804d74a3373dbb09477770ff4814e866 you have access to Icon on iced::window.
You can see here how I did it in my project running Iced:

https://github.com/casperstorm/ajour/blob/master/src/gui/mod.rs#L191-L197

@MCOfficer
Copy link
Member Author

Nice, i didn't know that! Let's hope 0.1.2 releases soon ;)

@MCOfficer
Copy link
Member Author

This has been done for Windows for a while (via winres), but other platforms will have to wait until iced glow gains image support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@casperstorm @MCOfficer