Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky external websites shouldn't fail the build #244

Open
ChrisJohnNOAA opened this issue Jan 21, 2025 · 0 comments
Open

Flaky external websites shouldn't fail the build #244

ChrisJohnNOAA opened this issue Jan 21, 2025 · 0 comments

Comments

@ChrisJohnNOAA
Copy link
Contributor

Describe the bug
Currently external sites that are not available (either temporarily or permanently) and are linked to from ERDDAP pages will cause the ERDDAP build to fail. While it is useful to know if external links are broken, failing the build is not the proper solution. A failing build should indicate ERDDAP internal problems.

This is a separate issue from flaky external data sources that are used in tests.

To Reproduce
See an example error here: https://github.com/ERDDAP/erddap/actions/runs/12890220698/job/35939294125

Expected behavior
Internal broken links can cause a failure in ERDDAP tests, but external links should not cause the build to fail. Broken external links should probably be a separate tool to run with it's own output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant