Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple alt alleles #18

Closed
apriltuesday opened this issue Aug 21, 2023 · 2 comments · Fixed by #24
Closed

Handle multiple alt alleles #18

apriltuesday opened this issue Aug 21, 2023 · 2 comments · Fixed by #24

Comments

@apriltuesday
Copy link
Collaborator

This is about how to appropriately handle rsIDs with more than one alternate allele. See #5 for some context.

PharmGKB provides variant-level clinical annotations with additional phenotype descriptions provided per genotype - for example this annotation for rs10420097. Open Targets uses VCF-style chr_pos_ref_alt variant identifiers that are allele-specific.

Currently the code explodes records by genotype but only generates one variant identifier for the RS (using the 1st alternate allele lexicographically), which doesn't seem appropriate.

We should discuss with Open Targets how they'd like the information presented and what is feasible to generate from the data, and update the implementation accordingly.

@apriltuesday
Copy link
Collaborator Author

Proposal from 29 Aug: replace variantID with genotypeID:

  • SNPs: 12_138521352_G_A,C & 12_138521352_G_A,A
  • indels: 19_38499645_GGAG_G,GGAG

@apriltuesday
Copy link
Collaborator Author

We forgot to talk about VEP, which of course predicts consequences for variants not genotypes... I guess we might need lists of consequences associated with a genotype? Might need to think about this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant