Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review classification of chromosome/scaffold #88

Open
jmmut opened this issue Sep 1, 2020 · 0 comments
Open

Review classification of chromosome/scaffold #88

jmmut opened this issue Sep 1, 2020 · 0 comments

Comments

@jmmut
Copy link
Collaborator

jmmut commented Sep 1, 2020

We allow enabling or disabling scaffold ingestion at compile time, but the classification of a sequence as "chromosome" or "scaffold" may not be completely right:

            if (!line.startsWith("#")) {
                parseChromosomeLine(line);
                String[] columns = line.split("\t", -1);
                if (columns.length >= 6) {
                    if (columns[3].equals("Chromosome")) {
                        parseChromosomeLine(columns);
                    } else if (isScaffoldsEnabled && columns[1].equals("unplaced-scaffold")) {
                        parseScaffoldLine(columns);
                    }
                }

for instance, the MT (in ftp://ftp.ncbi.nlm.nih.gov/genomes/all/GCA/000/001/405/GCA_000001405.14_GRCh37.p13/) won't be considered as either chromosome nor scaffold because its column[3] is Mitochondrion, not Chromosome, and its column[1] is assembled-molecule, not unplaced-scaffold.

Likewise, there are other contigs that are different to unplaced-scaffold. GCA_000001405.14 has some of them, like alt-scaffold, fix-patch and others, and we should decide whether to include them and in which category if so. (Including as Chromosome is meant for a small set of very used sequences, scaffolds for anything else).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant