Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible cause for Rectangular Matrix Bug #1

Closed
Dvd-Znf opened this issue Jul 24, 2023 · 2 comments
Closed

Possible cause for Rectangular Matrix Bug #1

Dvd-Znf opened this issue Jul 24, 2023 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Dvd-Znf
Copy link
Owner

Dvd-Znf commented Jul 24, 2023

for(int chi=0;chi<4;chi++){
if(resp1==structStack.name[chi] && structStack.index[chi][0]!=0 && structStack.index[chi][1]!=0){
for(int chj;chj<4;chj++){
if(resp2==structStack.name[chj] && structStack.index[chj][0]!=0 && structStack.index[chj][1]!=0){
matrixmulti(structStack.mat[chi],structStack.mat[chj],
structStack.index[chi][0],structStack.index[chi][1],
structStack.index[chj][0],structStack.index[chj][1]);
}
}

This may be the cause for the silly Rectangular Matrix bug
When pasrsing those indices, the order may be reversed

I’ll investigate this later

@Dvd-Znf Dvd-Znf added good first issue Good for newcomers bug Something isn't working labels Jul 24, 2023
@Dvd-Znf Dvd-Znf self-assigned this Jul 24, 2023
@Dvd-Znf
Copy link
Owner Author

Dvd-Znf commented Jul 25, 2023

Ok so the order in which all the variables are passed to the function is fine.
I seriously don't get what is causing the issue

The actual calculation part seems fine, but it breaks at the indices.
Maybe because the size of the resulting matrix is different??

@Dvd-Znf Dvd-Znf pinned this issue Jul 25, 2023
@Dvd-Znf
Copy link
Owner Author

Dvd-Znf commented Jul 25, 2023

This issue was finally fixed with 201e1ca commit 🎉 🎉 ❤️

@Dvd-Znf Dvd-Znf closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant