Fix ci: travis - Better test that phpunit really completed #32688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eldy This makes travis fail if phpunit does not have a test conclusion. In this PR it fails because the exit is still present in the SecurityTest.php. So this is proof that the extra code works when it fails. Later this can be backported to an older branch if you want. |
mdeweerd
changed the title
mdeweerd
force-pushed
the
fix/travis_phpunit_test
branch
from
d05f379 to
bbec07a
Compare
mdeweerd
force-pushed
the
fix/travis_phpunit_test
branch
3 times, most recently
from
1211a74 to
07b64b7
Compare
# Fix ci: travis - Better test if phpunit completed
mdeweerd
force-pushed
the
fix/travis_phpunit_test
branch
from
07b64b7 to
720b911
Compare
|
@eldy Further improved + showing message with result code instead of abruptly exiting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ci: travis - Better test that phpunit really completed
Check that phpunit completed by looking for the test summary.