QUAL remove unused jQuery-Jeditable #32640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdeweerd @frederic34 can you see this phan and php-stan errors ? thanks |
|
These are fixed in #32638 |
…ix_dev_remove_unused_jeditable
…ix_dev_remove_unused_jeditable
|
And after the removal if option MAIN_USE_EDIT_IN_PLACE is on, can you paste a screenshot to show what is result ? |
|
@eldy for the moment I just renamed the constant, we need to make a point with @lmag and @thersane-john in order to define the best way to integrate an "edit in place" in relation to this feature request : #32620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.