Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW fichinter list disable details option #30884

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

W1W1-M
Copy link
Contributor

@W1W1-M W1W1-M commented Sep 6, 2024

NEW fichinter list disable details option

Currently FICHINTER_DISABLE_DETAILS option will disable details for list view and card views of interventions. In some cases (like #30790 #25190 #7951) it is necessary to have intervention detail lines but not on the list view: only one intervention per line. This PR adds an explicit FICHINTER_DISABLE_DETAILS_ON_LIST option which replaces FICHINTER_DISABLE_DETAILS for the list view only. This means users can have the best of both depending on their needs and without having to fight with column settings.

If this PR is merged, intervention admin page could be updated to add these options to administration. Dolibarr wiki will also need updating.

@W1W1-M W1W1-M changed the title NEW fichinter list disable details NEW fichinter list disable details option Sep 6, 2024
@eldy
Copy link
Member

eldy commented Sep 9, 2024

FICHINTER_DISABLE_DETAILS_ON_LIST

Instead of adding new constant, i would prefer that we play on the value. For example:
FICHINTER_DISABLE_DETAILS = '0' // not disabled (like not set)
FICHINTER_DISABLE_DETAILS = '1' // lines disabled
FICHINTER_DISABLE_DETAILS = 'listonly' // Lines disabled on list only

Avoid to be lost when sharing all options, and avoid the "optionflation".

@eldy eldy added the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label Sep 9, 2024
@W1W1-M
Copy link
Contributor Author

W1W1-M commented Sep 10, 2024

FICHINTER_DISABLE_DETAILS_ON_LIST

Instead of adding new constant, i would prefer that we play on the value. For example: FICHINTER_DISABLE_DETAILS = '0' // not disabled (like not set) FICHINTER_DISABLE_DETAILS = '1' // lines disabled FICHINTER_DISABLE_DETAILS = 'listonly' // Lines disabled on list only

Avoid to be lost when sharing all options, and avoid the "optionflation".

Thanks for input. I've also updated Dolibarr wiki accordingly : https://wiki.dolibarr.org/index.php?title=Setup_Other#Interventions_Module

@eldy eldy merged commit 80ce987 into Dolibarr:develop Sep 13, 2024
7 checks passed
@silvianionescu
Copy link

In "fichinter/list", in practice it is easier to follow interventions, the details of interventions should appear in "fichinter/card", every detail of the intervention displayed in the lists creates confusion, especially when there are many interventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants