Loader factory function doesn't use MethodRepository or module_path params

[yousefmoazzam]

This is something to be aware of if there's any discussions around where new loaders should be put (if that is ever a thing, to add new loaders to httomo).

Currently, the make_loader() function that's used to create instances of LoaderInterface implementors takes in

• an implementor of MethodRepository
• a module path

which it doesn't actually use:

httomo/httomo/loaders/__init__.py

Lines 13 to 54 in ebd18a6

	def make_loader(
	repo: MethodRepository,
	module_path: str,
	method_name: str,
	in_file: Path,
	data_path: str,
	image_key_path: Optional[str],
	angles: AnglesConfig,
	darks: DarksFlatsFileConfig,
	flats: DarksFlatsFileConfig,
	preview: PreviewConfig,
	comm: MPI.Comm,
	) -> LoaderInterface:
	"""
	Factory function for creating implementors of `LoaderInterface`.
	Notes
	-----
	Currently, only `StandardLoaderWrapper` is supported (and thus only `StandardTomoLoader` is
	supported). Supporting other loaders is a topic that still needs to be explored.
	See Also
	--------
	standard_tomo_loader.StandardLoaderWrapper : The only supported loader-wrapper
	standard_tomo_loader.StandardTomoLoader : The only supported loader
	"""
	if "standard_tomo" not in method_name:
	raise NotImplementedError(
	"Only the standard_tomo loader is currently supported"
	)
	return StandardLoaderWrapper(
	comm=comm,
	in_file=in_file,
	data_path=data_path,
	image_key_path=image_key_path,
	darks=darks,
	flats=flats,
	angles=angles,
	preview=preview,
	)

Relevant questions are things like:

• would we ever need methods database info to create a loader (an implementor of LoaderInterface)
• if we have different loaders, would they all be put into one module in httomo (in which case a module path parameter may not be needed), or would different loaders potentially be split into different modules (in which case a module path parameter may be useful)