Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httomo-backends separation from httomo #429

Open
1 of 4 tasks
dkazanc opened this issue Aug 30, 2024 · 5 comments · May be fixed by #532
Open
1 of 4 tasks

httomo-backends separation from httomo #429

dkazanc opened this issue Aug 30, 2024 · 5 comments · May be fixed by #532

Comments

@dkazanc
Copy link
Collaborator

dkazanc commented Aug 30, 2024

Create a separate package which consists some current elements of httomo:

  • YAML templates for all backends
  • memory estimators
  • padding estimators
  • methods database files

The package will be built and uploaded to PyPi.

@namannimmo10
Copy link
Member

Some bits of the methods database folder use classes implemented in the runner and the cufft modules. For example,

  1. OutputRef usage for memory estimation:

  2. httomo.cufft usage in memory estimation:

  3. In this file as well, some classes are imported:

    from httomo.runner.methods_repository_interface import GpuMemoryRequirement, MethodQuery
    from httomo.utils import Pattern, log_exception
    from httomo.runner.methods_repository_interface import MethodRepository

Also, the fact that logging is added to query.py, it's fairly connected to the framework. To separate the methods database from httomo, we have to move these dependencies to httomo-backends or eliminate them. Yousef suggested getting rid of OutputRef earlier.

@yousefmoazzam
Copy link
Collaborator

httomo.cufft can be moved with the memory estimators; its only purpose is for memory estimation, and I believe that nowhere else in httomo is that module used apart from in a few memory estimators.

@yousefmoazzam
Copy link
Collaborator

I think query.py probably should stay in httomo. It's used by the framework to query the methods database, wherever the methods database happens to be located.

So, if the methods database is being moved elsewhere (ie, into httomo-backends), this means that the querying functionality needs to:

  • stay in httomo
  • but be modified to work with the methods database being located in httomo-backends

@yousefmoazzam
Copy link
Collaborator

For clarity, my suggestion regarding OutputRef wasn't "getting rid of it" (which sort of implies the removal of the class entirely), but to remove its usage in the memory estimator in morph.py by resolving #359.

@namannimmo10
Copy link
Member

OK, thanks - that can be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants