Potentially confusing print by YAML checker when checking a loader is first in the pipeline

[yousefmoazzam]

There's a check that is making sure that the first method in the pipeline YAML file is a loader:

httomo/httomo/yaml_checker.py

Lines 102 to 122 in 2e15a80

	def check_first_method_is_loader(conf: PipelineConfig) -> bool:
	"""
	Check that the first method in pipeline is a
	loader.
	"""
	first_stage = conf[0]
	module_path = first_stage["module_path"]
	_print_with_colour(
	"Checking that the first method in the pipeline is a loader...",
	colour=Colour.GREEN,
	)
	if module_path != "httomo.data.hdf.loaders":
	_print_with_colour(
	"The first method in the YAML_CONFIG file is not a loader from "
	"'httomo.data.hdf.loaders'. Please recheck the yaml file."
	)
	return False
	_print_with_colour("Loader check successful!!\n", colour=Colour.GREEN)
	return True

If the check passes, the message printed is:

httomo/httomo/yaml_checker.py

Line 120 in 2e15a80

_print_with_colour("Loader check successful!!\n", colour=Colour.GREEN)

However, in the event that:

• this check passes
• but other checks fail in the loader (such as a duplicate parameter)

this message being printed is confusing, because "loader check successful" implies that the loader config is error-free, but in reality this is not the case.

I think the message should be updated to be more specific in stating that the check for the first method being a loader was successful, to avoid such confusion in cases where the check passes but other checks that involve the loader fail. Maybe something like:

Loader first in pipeline check successful