Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'not external_tests' option to pytest #982

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olliesilvester
Copy link
Collaborator

Fixes #954
Enables us to run unit tests with pytest -m "not external_tests" rather than pytest -m "not (s03 or adsim)"

Instructions to reviewer on how to test:

  1. Confirm that running pytest "not external_tests" correctly skips s03 and adsim tests but nothing else

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (bbd76c6) to head (ce03d8f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         148      148           
  Lines        6238     6238           
=======================================
  Hits         6081     6081           
  Misses        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olliesilvester olliesilvester marked this pull request as ready for review January 10, 2025 15:37
@olliesilvester olliesilvester requested a review from a team as a code owner January 10, 2025 15:37
@olliesilvester olliesilvester force-pushed the 954_marker_for_unit_tests branch from 0630dce to ce03d8f Compare January 10, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pytest marker to easily run local unit tests
1 participant