Wait for eiger to disarm before stopping it #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
requested review from
rtuck99,
noemifrisina,
d-perl and
olliesilvester
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 152 152
Lines 6347 6354 +7
=======================================
+ Hits 6189 6196 +7
Misses 158 158 ☔ View full report in Codecov by Sentry. |
callumforrester
approved these changes
Nov 29, 2024
rtuck99
reviewed
Dec 3, 2024
| if not self.disarming_status.done: | ||
| LOGGER.info("Eiger still disarming, waiting on disarm") | ||
| self.disarming_status.wait(self.timeouts.arming_timeout) | ||
| else: |
There was a problem hiding this comment.
Perhaps this fixes the issue, but I'm unclear on what exactly we should do in stop(), looking at bluesky run_engine.py it seems stop() is invoked in a variety of scenarios, including at the end of a plan, during a suspend and when pause() is invoked. The impression I get is that being stopped is at least somewhat resumable.
There was a problem hiding this comment.
Sure but I think it's outside of the scope of this issue, I've made #994.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #935
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}