Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with current triplification pattern #64

Open
6 of 9 tasks
amoeba opened this issue Feb 10, 2022 · 5 comments
Open
6 of 9 tasks

Fix issues with current triplification pattern #64

amoeba opened this issue Feb 10, 2022 · 5 comments
Assignees
Milestone

Comments

@amoeba
Copy link
Contributor

amoeba commented Feb 10, 2022

Last week we worked through some example triples and found a few issues and areas for improvement. See https://hpad.dataone.org/9cvSZ4l0RaK-FHjlOcKmPw for a list of the hackpads we worked through. We pointed out issues directly in the hackpad, and an abridged list is:

  • Missing PROV in at least one case
  • Award structure doesn't match SOSO
  • Add all parties from metadata not just creator
  • Parties aren't following SOSO pattern
  • Missing checksum algorithm triple
  • Organization identifiers via ROR
  • variableMeasured triples could be more complete
  • Normalize people and org names
  • Updated funding pattern from SOSO. CreativeWork <- funding -> MonetaryGrant

See the linked hackpad for more info around each one. Most of these are quick fixes and can go in before our first release.

@amoeba amoeba self-assigned this Feb 10, 2022
@amoeba
Copy link
Contributor Author

amoeba commented Feb 24, 2022

Also revisit this paragraph to make sure all of this is captured:

I did a quick read through, @amoeba -- looking good. While there were a lot of particulars that we can pick up on later, a couple high-level points. For provenance, I think we should follow the DataONE provenance model as expressed in the SOSO provenance guidance. This will be quite compatible with Carl's approach, which is already pretty isomorphic with ProvONE albeit lacking some specific things. Second, when we have multiple values for a field, like for identifier with have PID, SID, and alternative Identifier fields, we can and should include them both, and follow SOSO guidance on indicating precedence and using sameAs in reasonable ways. For your example, it would be good to use an example that is pretty comprehensive and has both annotations and detailed provenance information to show how those would work. Finally, we should discuss the Dataset/Metadata/Entity/Package distinctions and how we will map those -- I was a little confused by your initial text around those. Nice work all around!

-- From #21 (comment)

@amoeba
Copy link
Contributor Author

amoeba commented Feb 25, 2022

Also bringing this in from our weekly call Re: EML units,

EML Units in slinky

  • Should bring the unit dictionary into Slinky as OWL and use that in triples (to avoid using string literals
  • Remember we made some changes to the units in 2.2.0, should upgrade any deprecated units we find in 2.2.0 docs to the new code

@amoeba amoeba added this to the 0.3.0 milestone Feb 26, 2022
amoeba added a commit that referenced this issue Feb 26, 2022
@amoeba
Copy link
Contributor Author

amoeba commented Feb 26, 2022

Made some good progress on this today and found a few more things that could use some work. I'll add those to the checklist above as I go.

@amoeba
Copy link
Contributor Author

amoeba commented Mar 17, 2022

Noting here that https://schema.org/funding is live.

amoeba added a commit that referenced this issue Aug 7, 2022
@amoeba
Copy link
Contributor Author

amoeba commented Aug 7, 2022

Added support for schema:funding in 7aa9d94 by mapping EML's award structure. We now get triples out like:

schema:funding <https://www.nsf.gov/awardsearch/showAward?AWD_ID=1417345> ;

<https://www.nsf.gov/awardsearch/showAward?AWD_ID=1417345>
    a schema:MonetaryGrant ;
    schema:funder <https://doi.org/10.13039/100000001> ;
    schema:identifier "1417345" ;
    schema:name "COLLABORATIVE RESEARCH:   Ice Regime Shifts of Arctic Lakes Drive Interactions and Feedbacks with Permafrost and Climate" ;
    schema:url "https://www.nsf.gov/awardsearch/showAward?AWD_ID=1417345" .

<https://doi.org/10.13039/100000001>
    a schema:Organization ;
    schema:identifier "https://doi.org/10.13039/100000001" ;
    schema:name "National Science Foundation" .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant