Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples] Allow Horizontal/Vertical Scrolling and Sizing requirements for Samples #74

Open
23 tasks
michael-hawker opened this issue Mar 13, 2023 · 1 comment
Labels
bug 🐛 Something isn't working regression What was working is now broke sample app 🖼

Comments

@michael-hawker
Copy link
Member

Describe the bug

Based on issues discovered trying to clean-up the design of the sample app in CommunityToolkit/Labs-Windows#356.

We need to allow some samples to control their:

  • min/max sizing of space for the sample display
  • whether they horizontally scroll their viewport
  • whether they vertically scroll their viewport

Steps to reproduce

N/A

Expected behavior

See CanvasLayout, we need to show a horizontally and vertically scrollable space for the component.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

@michael-hawker michael-hawker added bug 🐛 Something isn't working sample app 🖼 regression What was working is now broke labels Mar 13, 2023
@niels9001 niels9001 transferred this issue from CommunityToolkit/Labs-Windows Jun 22, 2023
@Arlodotexe Arlodotexe moved this to 📋 Backlog in Toolkit 8.x Jun 22, 2023
@michael-hawker
Copy link
Member Author

michael-hawker commented Jul 11, 2023

Hit this a few times now, first with CommunityToolkit/Labs-Windows#418 and then with CommunityToolkit/Windows#136

Just set Height="300" in those samples for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working regression What was working is now broke sample app 🖼
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant