Fix crash when multiple Android Service are active #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ne0rrmatrix
reviewed
Dec 28, 2024
| @@ -18,15 +18,20 @@ | |||
| namespace CommunityToolkit.Maui.Media.Services; | |||
|
|
|||
| [SupportedOSPlatform("Android26.0")] | |||
| [Service(Exported = false, Enabled = true, Name = "communityToolkit.maui.media.services", ForegroundServiceType = ForegroundService.TypeMediaPlayback)] | |||
| [Service(Exported = false, Enabled = true, Name = "CommunityToolkit.Maui.Media.Services", ForegroundServiceType = ForegroundService.TypeMediaPlayback)] | |||
There was a problem hiding this comment.
Changing the case to uppercase will break older API's compatibility and prevent app from running on Android 23 or below. We only support android 26+ now on media element but I do want to point out this would break some current apps. Also changing this here requires changing the string in the manifest to match which has not been done.
pictos
requested changes
Jan 9, 2025
Comment on lines
+24
to
+29
| public const string ActionPlay = "MediaAction.play"; | ||
| public const string ActionPause = "MediaAction.pause"; | ||
| public const string ActionUpdateUI = "CommunityToolkit.Maui.Services.action.UPDATE_UI"; | ||
| public const string ActionUpdatePlayer = "CommunityToolkit.Maui.Services.action.UPDATE_PLAYER"; | ||
| public const string ActionRewind = "MediaAction.rewind"; | ||
| public const string ActionFastForward = "MediaAction.fastForward"; |
There was a problem hiding this comment.
Why did you change the pattern? Can you revert and follow our pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information