Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary use of sudo #1

Open
jjwedemyer opened this issue Jun 26, 2020 · 0 comments · May be fixed by #2
Open

Unnecessary use of sudo #1

jjwedemyer opened this issue Jun 26, 2020 · 0 comments · May be fixed by #2

Comments

@jjwedemyer
Copy link

Hi,
it seems like you are using sudo here without need?

knotci/deployzones.sh

Lines 50 to 51 in 1c4186a

ssh "$SSH_USER"@"$NS_HIDDENMASTER" sudo knotc zone-reload "$zone"
ssh "$SSH_USER"@"$NS_HIDDENMASTER" sudo knotc zone-status "$zone"

in the first clause where all zones are issued for reload, it seems like there's a correct solution already?

knotci/deployzones.sh

Lines 44 to 45 in 1c4186a

ssh "$SSH_USER"@"$NS_HIDDENMASTER" knotc reload
ssh "$SSH_USER"@"$NS_HIDDENMASTER" knotc zone-status

P.S.: Awesome set of scripts provided here, these are easy to use.
Thank you for providing your work openly. 🙏
@jjwedemyer jjwedemyer linked a pull request Jun 26, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing unnecessary use of sudo in zone reload jjwedemyer/knotci
1 participant
@jjwedemyer