Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due to instant sharing active, scheduled posts are shared instantly inaccessible #917

Open
AndreeaCristinaRadacina opened this issue Feb 17, 2024 · 5 comments · Fixed by #932
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. Priority-Medium Expected resolution time - up to 1 month. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@AndreeaCristinaRadacina

Description

A user reported that when instant sharing is active, the posts that are scheduled in WP are instantly shared on social platforms, and once clicked, the user is redirected to a 404 page until the schedule condition is fulfilled.

ref: https://wordpress.org/support/topic/post-shared-when-scheduled/

Step-by-step reproduction instructions

  1. Go to ROP and connect to a social platform
  2. Make sure you activate the instant sharing options in General Settings: Enable Instant Sharing Feature (Post on Publish); Use True Instant Share; Enable Instant Sharing By Default.
  3. Go to Posts > Add new and schedule a new post
image
4. Go to the social platform and see the link of the scheduled post

Screenshots, screen recording, code snippet or Help Scout ticket

The post scheduled for tomorrow is already shared, and the link points to a 404 page:
image

Environment info

No response

Is the issue you are reporting a regression

No

@AndreeaCristinaRadacina AndreeaCristinaRadacina added the bug This label could be used to identify issues that are caused by a defect in the product. label Feb 17, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Feb 17, 2024
@vytisbulkevicius vytisbulkevicius added the Priority-Medium Expected resolution time - up to 1 month. label Feb 17, 2024
@Soare-Robert-Daniel
Copy link
Contributor

@vytisbulkevicius @mghenciu I think we might need some clarification for the instant sharing feature.

Instant share triggers the sharing immediately, as the name suggested.

We have a dedicated option for scheduling posts. They are shared when it hits the time set.

image


Users who use instant sharing and want the post published on a schedule should disable instant share for page (uncheck the box) and activate the schedules sharing option in the dashboard.

Also, I checked the code to see if the wanted behavior in the reported issue is somehow present and not functional. After reviewing, the workflow is not made with instant sharing as a part of scheduled post.

@Soare-Robert-Daniel
Copy link
Contributor

One trick I can do is stop the running of this code for scheduled posts if the Share Scheduled Posts is active.

https://github.com/Codeinwp/tweet-old-post/blob/master/includes/admin/class-rop-admin.php#L870-L881

@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Mar 3, 2024
@vytisbulkevicius
Copy link
Contributor

@Soare-Robert-Daniel,

But Instant sharing should share only sharing Published posts, why is it sharing Scheduled posts?
I think the rule that should be in place is for the Instant Sharing functionality to check for Published posts available and Ignore any other type of posts.

@AndreeaCristinaRadacina
Copy link
Author

@AndreeaCristinaRadacina
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. Priority-Medium Expected resolution time - up to 1 month. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants