New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript definition bugs/tweaks. #20

Open

niemyjski opened this issue Feb 20, 2013 · 1 comment

niemyjski commented Feb 20, 2013

I'm leaving this feedback here as you guys submitted a typescript def.

I noticed a typescript def bug when I tried doing the following:

new ko.DirtyFlag([observablebool, observablenumber]);

I ended up having to do this to get it to compile:
new ko.DirtyFlag([observablebool, observablenumber]);

Also, You have commands defined as KoliteCommand but the interface for Dirty is DirtyFlag, I was thinking it would be KoliteDirtyFlag.

Also if you specify a property type for DirtyFlag, you can't create a new instance of it in your constructor. It really complains about it.

rposener commented Dec 12, 2017

@niemyjski - Typescript definitions were recently updated. Can you update to the latest and let us know if that solves your concerns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment