Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

significant overlap among primitives #4

Open
qk98 opened this issue Nov 2, 2023 · 1 comment
Open

significant overlap among primitives #4

qk98 opened this issue Nov 2, 2023 · 1 comment

Comments

@qk98
Copy link

qk98 commented Nov 2, 2023

In the generated result, there is a significant overlap among primitives, such as the chair-leg and back shown in the image. The green primitive appears to be redundant. Is this expected, and how can it be adjusted?

Input:
image

result:
image

without GREEN primitive:
image

without CYAN:
image

@bmlklwx
Copy link
Collaborator

bmlklwx commented Nov 13, 2023

@qk98 Hi, thanks for your interest in our algorithm. This might happen, but could be mitigated by the following tips:
First, allow more iterations for each superquadric optimization (maxOptiIter), which can give each superquadric more chance to converge.
Second, a lower input SDF resolution might help.
Moreover, increase minArea can make the algorithm ignore tiny unfitted volumes where new superquadrics might appear.
Lastly, of course, a post-process will help. For example, check if the removal of a superquadric will affect the overall fitting quality (difference between input and superquadric SDFs). If not, we can remove it. I haven't had time to implement any post-process, but I believe this will help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants