Support freebsd (OPNsense etc) for the included plugin isc_dhcpd #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support freebsd (OPNsense etc)
`/usr/local/etc/dhcpd.conf` does exist on OPNsense but is entirely ignored, `/var/dhcpd/etc/dhcpd.conf` is the one that is used by the ISC. Adding a configuration file for the plugin would solve the issue finding `dhcpd.conf` and `dhcpd.leases` entirely.
dnlldl
changed the title
|
is there any chance of this making it in eventually? |
|
I looked at it and approved it from a product perspective and forward it to a dev for analysis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support freebsd (OPNsense etc)
Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.
General information
This is to make the isc_dhcpd plugin work with any recent version of OPNsense.
Proposed changes
The
dhcpd.leasesfile is in a different location than expected by the script. The commandpidofdoesn't exist andawkis also more limited.This PR could be improved, using a configuration file instead of hardcoding the necessary files would be good. Also, for the
pidofproblem,which pidofcould be used before falling back to something more universal withps.I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.