SIGNL4 Notification Plugin Update #603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Fixed Range Check I realized that SIGNL4 notifications fail in beta 3 with "Details for Status Code are not defined -- 201: Created". However, 201 should be success. The reason seems to be that the line: if status_code in status_code_range: returns true for 200 and 299. But the line if status_code_range[0] <= status_code <= status_code_range[1]: returns true for any value between 200 and 299. The change should make sure that all 2xx status codes are processed as success. I hope this makes sense and I did not miss anything.
Updated SIGNL4 notification plugin for better support of service alerting and two-way status updates.
Updated SIGNL4 notification plugin for better support of service alerting and two-way status updates.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA. |
|
recheck |
3 similar comments
|
recheck |
|
recheck |
|
recheck |
makanakoeln
requested changes
Oct 23, 2023
makanakoeln
requested changes
Oct 24, 2023
|
Sorry for the confusion. I checked the code again and we don't just use the service description for matching, we already use a combination of several values. "X-S4-ExternalID": "Checkmk: " We use this for matching and for sending updates from our side (SIGNL4) back to Checkmk. I hope this is fine then. |
makanakoeln
approved these changes
Oct 30, 2023
|
merged today. Thanks for contributing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.
General information
This is an update of the SIGNL4 notification plugin for better support for service alerting and two-way status updates.
We are the provider of SIGNL4.
If you should have any questions please just let me know.