From d901721c01a923b0c271a946c9e9dd79e8f88fe1 Mon Sep 17 00:00:00 2001
From: Moritz Kirschner <moritz.kirschner@checkmk.com>
Date: Wed, 13 Nov 2024 18:13:29 +0100
Subject: [PATCH] vue: Allow configuration of any/none of conditions

Still missing:
* Styling/margin issue fix
* Switch buttons order of condition group dropdown
* Readonly mode
* Condition group dropdown filtering

CMK-19266

Change-Id: Ia3e297ffa4063c2b520cccbda3aacf7e6103917a
---
 .../src/components/CmkList/CmkList.vue        |  2 +-
 .../src/components/CmkList/CmkListItem.vue    |  5 +-
 .../ConditionChoice.vue                       | 99 ++++++++++++++++---
 .../FormConditionChoices.vue                  |  3 +-
 4 files changed, 92 insertions(+), 17 deletions(-)

diff --git a/packages/cmk-frontend-vue/src/components/CmkList/CmkList.vue b/packages/cmk-frontend-vue/src/components/CmkList/CmkList.vue
index bd525250439..452ba673134 100644
--- a/packages/cmk-frontend-vue/src/components/CmkList/CmkList.vue
+++ b/packages/cmk-frontend-vue/src/components/CmkList/CmkList.vue
@@ -114,7 +114,7 @@ function getStyle(index: number, length: number) {
       <template v-else>
         <tr>
           <td v-for="(dataIndex, listIndex) in localOrder" :key="dataIndex">
-            <CmkListItem :button-padding="'4px'" :remove-element="() => removeElement(dataIndex)">
+            <CmkListItem :button-padding="'8px'" :remove-element="() => removeElement(dataIndex)">
               <slot name="item-props" v-bind="{ index: dataIndex, ...getItemProps(dataIndex) }" />
               <CmkSpace direction="horizontal" />
               <CmkSpace v-if="listIndex !== localOrder.length - 1" direction="horizontal" />
diff --git a/packages/cmk-frontend-vue/src/components/CmkList/CmkListItem.vue b/packages/cmk-frontend-vue/src/components/CmkList/CmkListItem.vue
index 129b0a827b8..67df6ce44ae 100644
--- a/packages/cmk-frontend-vue/src/components/CmkList/CmkListItem.vue
+++ b/packages/cmk-frontend-vue/src/components/CmkList/CmkListItem.vue
@@ -8,9 +8,10 @@ import CmkButton from '@/components/CmkButton.vue'
 import CmkIcon from '@/components/CmkIcon.vue'
 import CmkSpace from '@/components/CmkSpace.vue'
 
-const props = defineProps<{
+const { buttonPadding = '16px', ...props } = defineProps<{
   removeElement: () => void
   style?: 'first' | 'last' | null
+  buttonPadding?: '16px' | '8px'
   draggable?: {
     dragStart: (event: DragEvent) => void
     dragEnd: (event: DragEvent) => void
@@ -70,7 +71,7 @@ const props = defineProps<{
 
   .cmk_list__content {
     padding-top: calc(var(--spacing) - var(--button-padding-top));
-    padding-left: 16px;
+    padding-left: v-bind(buttonPadding);
   }
 
   .cmk_list__buttons.first {
diff --git a/packages/cmk-frontend-vue/src/form/components/forms/form_condition_choices/ConditionChoice.vue b/packages/cmk-frontend-vue/src/form/components/forms/form_condition_choices/ConditionChoice.vue
index 02b7842fafe..5e84e6f3cd1 100644
--- a/packages/cmk-frontend-vue/src/form/components/forms/form_condition_choices/ConditionChoice.vue
+++ b/packages/cmk-frontend-vue/src/form/components/forms/form_condition_choices/ConditionChoice.vue
@@ -4,11 +4,13 @@ This file is part of Checkmk (https://checkmk.com). It is subject to the terms a
 conditions defined in the file COPYING, which is part of this source code package.
 -->
 <script setup lang="ts">
+import CmkList from '@/components/CmkList'
 import CmkSpace from '@/components/CmkSpace.vue'
 import DropDown from '@/components/DropDown.vue'
 import {
   type ConditionChoicesValue,
-  type ConditionGroup
+  type ConditionGroup,
+  type Condition
 } from '@/form/components/vue_formspec_components'
 import { immediateWatch } from '@/lib/watch'
 import { computed, ref, watch } from 'vue'
@@ -21,6 +23,7 @@ const props = defineProps<{
     ne: string
     or: string
     nor: string
+    add_condition_label: string
   }
 }>()
 
@@ -33,13 +36,26 @@ type Operator = KeysOfUnion<ConditionChoicesValue['value']>
 const operatorIsMultiSelect = (operator: Operator) => operator === 'or' || operator === 'nor'
 
 const selectedOperator = ref<Operator>('eq')
-const selectedValue = ref<string>(props.group.conditions[0]!.name)
+const selectedSingleValue = ref<string>(props.group.conditions[0]!.name)
+const selectedMultiValue = ref<string[]>([props.group.conditions[0]!.name])
+
+const remainingConditions = ref<Condition[]>(props.group.conditions)
 
 immediateWatch(
   () => props.data,
   (data) => {
-    selectedOperator.value = Object.keys(data.value)[0] as Operator
-    selectedValue.value = Object.values(data.value)[0]
+    const operator = Object.keys(data.value)[0] as Operator
+    selectedOperator.value = operator
+    if (operatorIsMultiSelect(operator)) {
+      selectedMultiValue.value = Object.values(data.value)[0] as string[]
+      selectedSingleValue.value = props.group.conditions[0]!.name
+    } else {
+      selectedSingleValue.value = Object.values(data.value)[0] as string
+      selectedMultiValue.value = [props.group.conditions[0]!.name]
+    }
+    remainingConditions.value = props.group.conditions.filter(
+      ({ name }) => !selectedMultiValue.value.includes(name)
+    )
   }
 )
 
@@ -58,7 +74,7 @@ const operatorChoices = computed<{ name: Operator; title: string }[]>(() => {
   ]
 })
 
-const valueChoices = computed(() => {
+const allValueChoices = computed(() => {
   return props.group.conditions.map((condition) => {
     return { name: condition.name, title: condition.title }
   })
@@ -68,16 +84,39 @@ const emit = defineEmits<{
   update: [value: ConditionChoicesValue]
 }>()
 
-watch([selectedOperator, selectedValue], ([operator, _value]) => {
-  if (operator === undefined || _value === undefined) {
-    return
-  }
+function updateValue(operator: Operator, value: string | string[] | null) {
   emit('update', {
     group_name: props.data.group_name,
     value: {
-      [operator]: operatorIsMultiSelect(operator) ? [_value] : _value
+      [operator]: value
     } as { eq: string } | { ne: string } | { or: string[] } | { nor: string[] }
   })
+}
+
+function addMultiValue() {
+  selectedMultiValue.value.push(remainingConditions.value[0]!.name)
+  updateValue(selectedOperator.value, selectedMultiValue.value)
+}
+
+function deleteMultiValue(index: number) {
+  selectedMultiValue.value.splice(index, 1)
+  updateValue(selectedOperator.value, selectedMultiValue.value)
+}
+
+function updateMultiValue(index: number, value: string) {
+  selectedMultiValue.value[index] = value
+  updateValue(selectedOperator.value, selectedMultiValue.value)
+}
+
+watch(selectedOperator, (operator) => {
+  if (operatorIsMultiSelect(operator)) {
+    if (selectedMultiValue.value.some((v) => v === null)) {
+      return
+    }
+    updateValue(operator, selectedMultiValue.value as string[])
+  } else {
+    updateValue(operator, selectedSingleValue.value)
+  }
 })
 </script>
 
@@ -85,10 +124,44 @@ watch([selectedOperator, selectedValue], ([operator, _value]) => {
   {{ group.title }}
   <DropDown v-model:selected-option="selectedOperator" :options="operatorChoices" />
   <CmkSpace :size="'small'" />
-  <template v-if="valueChoices.length === 1">
-    {{ valueChoices[0]!.title }}
+  <template v-if="allValueChoices.length === 1">
+    {{ allValueChoices[0]!.title }}
+  </template>
+  <template v-else-if="operatorIsMultiSelect(selectedOperator)">
+    <CmkList
+      :items-props="{ selectedValue: selectedMultiValue }"
+      :on-add="addMultiValue"
+      :on-delete="deleteMultiValue"
+      :i18n="{ addElementLabel: props.i18n.add_condition_label }"
+      :orientation="'horizontal'"
+      :show-add-button="remainingConditions.length > 0"
+    >
+      <template #item-props="{ index, selectedValue }">
+        <DropDown
+          :selected-option="selectedValue"
+          :disabled="remainingConditions.length === 0"
+          :options="[
+            ...props.group.conditions
+              .filter(({ name }) => name === selectedValue)
+              .map((condition) => ({
+                name: condition.name,
+                title: condition.title
+              })),
+            ...remainingConditions.map((condition) => ({
+              name: condition.name,
+              title: condition.title
+            }))
+          ]"
+          @update:selected-option="(value) => updateMultiValue(index, value!)"
+        />
+      </template>
+    </CmkList>
   </template>
   <template v-else>
-    <DropDown v-model:selected-option="selectedValue" :options="valueChoices" />
+    <DropDown
+      :selected-option="selectedSingleValue"
+      :options="allValueChoices"
+      @update:selected-option="(value) => updateValue(selectedOperator, value)"
+    />
   </template>
 </template>
diff --git a/packages/cmk-frontend-vue/src/form/components/forms/form_condition_choices/FormConditionChoices.vue b/packages/cmk-frontend-vue/src/form/components/forms/form_condition_choices/FormConditionChoices.vue
index c3e6b238ea3..c400189f64c 100644
--- a/packages/cmk-frontend-vue/src/form/components/forms/form_condition_choices/FormConditionChoices.vue
+++ b/packages/cmk-frontend-vue/src/form/components/forms/form_condition_choices/FormConditionChoices.vue
@@ -61,7 +61,8 @@ function updateElementData(newValue: typing.ConditionChoicesValue, index: number
           eq: props.spec.i18n.eq_operator,
           ne: props.spec.i18n.ne_operator,
           or: props.spec.i18n.or_operator,
-          nor: props.spec.i18n.nor_operator
+          nor: props.spec.i18n.nor_operator,
+          add_condition_label: props.spec.i18n.add_condition_label
         }"
         @update="(new_value: typing.ConditionChoicesValue) => updateElementData(new_value, index)"
       />