From b57ccabb7bb063083823d78fdee4887b8bce2f20 Mon Sep 17 00:00:00 2001
From: Zoey Hilton <zoey.hilton@checkmk.com>
Date: Wed, 15 Jan 2025 09:27:54 +0100
Subject: [PATCH] 17550 FIX Fix webauthn incorrectly displaying error message
 on login

When using the webauthn functionaility for two factor within Checkmk,
an error would previously display on successful login.

This error did not impact the use of this functionaility but was not
intended to be displayed.

Change-Id: I27c0e45aff2e722022b5d54b60b8f4c6e61e6a9d
---
 .werks/17550.md                               | 18 ++++++++++++++++++
 cmk/gui/wato/pages/user_profile/two_factor.py |  3 ++-
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 .werks/17550.md

diff --git a/.werks/17550.md b/.werks/17550.md
new file mode 100644
index 00000000000..ef66fbb3606
--- /dev/null
+++ b/.werks/17550.md
@@ -0,0 +1,18 @@
+[//]: # (werk v2)
+# Fix webauthn incorrectly displaying error message on login
+
+key        | value
+---------- | ---
+date       | 2025-01-15T08:19:09+00:00
+version    | 2.3.0p25
+class      | fix
+edition    | cre
+component  | wato
+level      | 1
+compatible | yes
+
+When using the webauthn functionaility for two factor within Checkmk,
+an error would previously display on successful login.
+
+This error did not impact the use of this functionaility but was not 
+intended to be displayed.
diff --git a/cmk/gui/wato/pages/user_profile/two_factor.py b/cmk/gui/wato/pages/user_profile/two_factor.py
index 527c971706c..bd4affe8894 100644
--- a/cmk/gui/wato/pages/user_profile/two_factor.py
+++ b/cmk/gui/wato/pages/user_profile/two_factor.py
@@ -1084,5 +1084,6 @@ def page(self) -> JsonSerializable:
             raise
 
         session.session_info.webauthn_action_state = None
-        handle_success_auth(user.id)
+        session.session_info.two_factor_completed = True
+        save_custom_attr(user.id, "num_failed_logins", 0)
         return {"status": "OK"}