Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create python 3.11 compatible release for pypi #839

Closed
schlenk opened this issue Dec 14, 2022 · 2 comments
Closed

Create python 3.11 compatible release for pypi #839

schlenk opened this issue Dec 14, 2022 · 2 comments
Assignees

Comments

@schlenk
Copy link
Collaborator

schlenk commented Dec 14, 2022

The issue fixed with #827 does not only affect type checking with mypy.

It actually prevents users to run the Client code, due to the typing usage in the settings setattr method.

site-packages\oic\oic\__init__.py", line 354, in __init__
    self.settings = settings or OicClientSettings()
site-packages\oic\utils\settings.py", line 96, in __init__
     super().__init__(
site-packages\oic\utils\settings.py", line 51, in __init__
     self.client_cert = client_cert
site-packages\oic\utils\settings.py", line 73, in __setattr__
     raise SettingsException(

oic.utils.settings.SettingsException: client_cert has a type of <class 'NoneType'>, expected any of (<class 'str'>, <class 'tuple'>).

So publishing a fixed version to pypi would be quite useful.

I could try to prepare things, but at least for the actual upload to pypi i think either @tpazderka or @rohe need to do the push.

See also: #838

@tpazderka
Copy link
Collaborator

I will do it later today.

@tpazderka
Copy link
Collaborator

Uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants