From ec304e1ba8111812f24ff923bb132645f7e7340b Mon Sep 17 00:00:00 2001
From: shaselton-usds <shaselton.usds@gmail.com>
Date: Tue, 23 Jan 2024 11:40:32 -0800
Subject: [PATCH] adding stricter schema requirements to ensure attributes have
 values

---
 src/versions/2.0/json.ts | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/src/versions/2.0/json.ts b/src/versions/2.0/json.ts
index 1a68bd1..200dcac 100644
--- a/src/versions/2.0/json.ts
+++ b/src/versions/2.0/json.ts
@@ -21,7 +21,7 @@ const STANDARD_CHARGE_DEFINITIONS = {
   code_information: {
     type: "object",
     properties: {
-      code: { type: "string" },
+      code: { type: "string", minLength: 1 },
       type: {
         enum: BILLING_CODE_TYPES,
         type: "string",
@@ -32,7 +32,7 @@ const STANDARD_CHARGE_DEFINITIONS = {
   drug_information: {
     type: "object",
     properties: {
-      unit: { type: "string" },
+      unit: { type: "string", minLength: 1 },
       type: { enum: DRUG_UNITS, type: "string" },
     },
     required: ["unit", "type"],
@@ -65,7 +65,7 @@ const STANDARD_CHARGE_DEFINITIONS = {
   standard_charge_information: {
     type: "object",
     properties: {
-      description: { type: "string" },
+      description: { type: "string", minLength: 1 },
       drug_information: { $ref: "#/definitions/drug_information" },
       code_information: {
         type: "array",
@@ -83,8 +83,8 @@ const STANDARD_CHARGE_DEFINITIONS = {
   payers_information: {
     type: "object",
     properties: {
-      payer_name: { type: "string" },
-      plan_name: { type: "string" },
+      payer_name: { type: "string", minLength: 1 },
+      plan_name: { type: "string", minLength: 1 },
       additional_payer_notes: { type: "string" },
       standard_charge_dollar: { type: "number", exclusiveMinimum: 0 },
       standard_charge_algorithm: { type: "string" },
@@ -102,7 +102,7 @@ const STANDARD_CHARGE_DEFINITIONS = {
 const STANDARD_CHARGE_PROPERTIES = {
   type: "object",
   properties: {
-    description: { type: "string" },
+    description: { type: "string", minLength: 1 },
     drug_information: { $ref: "#/definitions/drug_information" },
     code_information: {
       type: "array",
@@ -134,7 +134,7 @@ export const METADATA_DEFINITIONS = {
         type: "string",
       },
     },
-    required: ["license_number", "state"],
+    required: ["state"],
   },
   affirmation: {
     type: "object",
@@ -154,9 +154,11 @@ export const METADATA_DEFINITIONS = {
     properties: {
       description: {
         type: "string",
+        minLength: 1,
       },
       code: {
         type: "string",
+        minLength: 1,
       },
       modifier_payer_information: {
         type: "array",
@@ -173,12 +175,15 @@ export const METADATA_DEFINITIONS = {
     properties: {
       payer_name: {
         type: "string",
+        minLength: 1,
       },
       plan_name: {
         type: "string",
+        minLength: 1,
       },
       description: {
         type: "string",
+        minLength: 1,
       },
     },
     required: ["payer_name", "plan_name", "description"],
@@ -186,21 +191,23 @@ export const METADATA_DEFINITIONS = {
 }
 
 export const METADATA_PROPERTIES = {
-  hospital_name: { type: "string" },
+  hospital_name: { type: "string", minLength: 1 },
   last_updated_on: { type: "string", format: "date" },
   license_information: {
     $ref: "#/definitions/license_information",
   },
-  version: { type: "string" },
+  version: { type: "string", minLength: 1 },
   hospital_address: {
     type: "array",
     items: { type: "string" },
+    minItems: 1,
   },
   hospital_location: {
     type: "array",
     items: {
       type: "string",
     },
+    minItems: 1,
   },
   affirmation: {
     $ref: "#/definitions/affirmation",