Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

<h1> is empty #19

Open
Kataract opened this issue Jan 9, 2018 · 2 comments
Open

<h1> is empty #19

Kataract opened this issue Jan 9, 2018 · 2 comments

Comments

@Kataract
Copy link
Member

Kataract commented Jan 9, 2018

Offending source code:

<h1><a href="https://www.clepy.org"></a></h1>

I recommend condensing the link, logo and "The Cleveland Python User Group" text to all be contained within the <h1>. This will also remove a duplicate link.

@mUtterberg
Copy link
Contributor

mUtterberg commented Oct 17, 2018

I'm adding an aria-label to a bunch of links in the theme and to the h1 mentioned here. @Kataract Are the items to condense (link, logo, and subtitle) all currently styled as h1? I'm not sure I 100% understand the recommendation, but I can at least put in a temporary fix! And I juuuuuuuuuust learned about aria-labelledby, which seems to be preferred over aria-label in the long run. But I believe aria-label is acceptable for now? Good lord, there's so much detail about ARIA. O.o

@Kataract
Copy link
Member Author

So aria-labelledby is neat if there's another element in the DOM that would achieve the same purpose (in terms of text content) - in this case we could have the offending <h1> instead have something like

<h1><a href="url" aria-labelledby="clepy"></a></h1>

but I worry about how "CLEpy" would be pronounced (hence the suggestion to move the paragraph tag in to the header). You can style the text so it doesn't have the heavy header font if that's an issue.

Another suggestion would be to remove the <h1> from around the logo and replace the <p> below it with that <h1> tag - something like

<a href="url" aria-label="CLEpy homepage"></a>
<h1>The Cleveland Python User Group</h1>

Aside:
aria-label is cool when you have something weird like an abbreviation that you aren't sure will be read right, and you want to provide proper wording without hosing your visuals. The only hard part with this is if you're auto-generating localizations, you want to handle aria-labels in the same way...but I feel like that's not a concern here at this point 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants