Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: code first for easy editing and then display result #661

Open
biumiamy opened this issue Oct 7, 2024 · 4 comments · May be fixed by #678
Open

v3: code first for easy editing and then display result #661

biumiamy opened this issue Oct 7, 2024 · 4 comments · May be fixed by #678
Assignees

Comments

@biumiamy
Copy link
Collaborator

biumiamy commented Oct 7, 2024

if there's a lot of output, it can get very messy, even if we reduce the output to less..

One example here: (underneath here) https://journalofdigitalhistory.netlify.app/en/article/BuWvtJFxh3wy?v=3

2024-10-07 14_14_35-Journal of Digital History

@biumiamy biumiamy assigned danieleguido and unassigned danieleguido Oct 7, 2024
@biumiamy
Copy link
Collaborator Author

biumiamy commented Oct 8, 2024

maybe we can ask Fred?

@frederic-reis
Copy link
Collaborator

Hello, I will take this opportunity to summarise the situation about the code.
There are 3 possibles visualisations for the code:

  1. The code is displayed in a fix-height block which can be expanded with a button. The code can be edited and ran with Thebe. The explain code feature is also proposed
  2. The code is hided by default and can be displayed with a toggle show/hide button. No edit, run or explain code features
  3. The code is not displayed at all. It's used for cover. (cover tag)

We still have to determine when the point 2 (hided code) is used (tags ?). For the moment, ti's only used for sound on this article: https://journalofdigitalhistory.org/en/article/6ig87tC5GKjQ

Regarding the ticket request, I put the code first for point 1 and 2 ?

@eliselavy
Copy link
Collaborator

Hello, I will take this opportunity to summarise the situation about the code. There are 3 possibles visualisations for the code:

  1. The code is displayed in a fix-height block which can be expanded with a button. The code can be edited and ran with Thebe. The explain code feature is also proposed
  2. The code is hided by default and can be displayed with a toggle show/hide button. No edit, run or explain code features
  3. The code is not displayed at all. It's used for cover. (cover tag)

We still have to determine when the point 2 (hided code) is used (tags ?). For the moment, ti's only used for sound on this article: https://journalofdigitalhistory.org/en/article/6ig87tC5GKjQ

Regarding the ticket request, I put the code first for point 1 and 2 ?

@biumiamy @danieleguido
I would not be in favour to add extra tag ( as for sure it would an extra work for the editorial team) but it's the problem with image , or if you can determine a bit with a regex ( type Image()) , if not computational figure hide the code
Screenshot 2024-11-29 at 14 34 22

@frederic-reis
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants