Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Thebe #623

Open
eliselavy opened this issue Mar 18, 2024 · 8 comments
Open

Integrate Thebe #623

eliselavy opened this issue Mar 18, 2024 · 8 comments
Assignees

Comments

@eliselavy
Copy link
Collaborator

eliselavy commented Mar 18, 2024

Scenario needs to be testing:

  • connection with mybinder
  • rededition of the code
  • execution notebook

In parallel with new UX integration

REACT_APP_PROXY=https://journalofdigitalhistory.org/
REACT_APP_THEBE_TOKEN=some-development-token
REACT_APP_THEBE_DEV_BINDER=true

?v=3 to test

@danieleguido
Copy link
Collaborator

danieleguido commented Mar 26, 2024

Design challenges

for @biumiamy :D

  • "Play with the article" to be transformed, how the new modality works with "open in binder" and "check on Github"?
  • notebooks are linear, we can't have layer anymore Concept of hermeneutic layer should change (background?)
  • How to start the interaction mode?
  • status and logs of the server
  • Status and actions of each cell (Run cell, Run all cells before)
  • Editor mode should act like open leaf with output on the right
  • Question: AI assistance?
  • add syntax highlight ion current codemirror editor

AI explain code

Example of "AI exlain" from https://www.datacamp.com/tutorial/python-linked-lists Screenshot 2024-03-26 at 11 05 06 see also: https://community.openai.com/t/explaining-the-code-on-your-browser-at-the-click-of-a-button/14647

table of contents?

with multiple layers already visible, better to hide it
Screenshot 2024-03-26 at 11 13 01

@eliselavy eliselavy changed the title Integrate Thebe in development with mybinder Integrate Thebe Mar 26, 2024
@biumiamy
Copy link
Collaborator

example from Observable

2024-03-26 11_01_32-AsBorder

@eliselavy
Copy link
Collaborator Author

@eliselavy
Jupyter button needs to take url from the database

@biumiamy
Copy link
Collaborator

biumiamy commented Mar 27, 2024

useable article: http://10.240.4.179/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZqZGgtb2JzZXJ2ZXIlMkZqbmtxcVRUS1c4a20lMkZtYWluJTJGcGFwZXIuaXB5bmI=?v=3

Here is the repo: https://github.com/jdh-observer/jnkqqTTKW8km

Women in Early Modern Handwritten News: Random Walks and Semantic Wanderings in the Medici Archive

@biumiamy
Copy link
Collaborator

ToC in Observable

Image

@eliselavy
Copy link
Collaborator Author

eliselavy commented Apr 11, 2024

See figma / video in slack

  • Estimate time in order to be ready for DH Washington
  • Start session in the background?

@danieleguido
Copy link
Collaborator

see PR #637

@biumiamy
Copy link
Collaborator

biumiamy commented Jun 20, 2024

desired outcome:

  • article in Digital Tools
  • guideline update
  • v3 design with explain code

ToDos:

  • Collapsed Codemirror Cells: Expand on click and enable write mode
  • Code Cell Output: The output result of a code cell should have the same background so that it’s clear it’s a direct output. Figure captions can be white on a black background.
  • Simpler Table of Content: Tailored to the new layout, possibly for me? Show the cell being executed with a simple green dot.

Other Minor Changes:

  • Remove numbers from the layer top as there’s no special meaning for them, or reduce their font size.
  • Adapt the black background to a dark purple for code cells.

On the Roadmap to Washington DC:

  • Connect “run code cell” with “start” and add a pending status for the run code cell button.
  • When the kernel connection starts, the run code cell has a ready status.
  • When a cell is executing, the run code cell button has an executing status.
  • When a cell is executed, a green tick appears with the last execution datetime (to be refined at a later stage).
  • Status can be shown in button

Two levels of code

  • if the tag is data = editable code
  • show/hide collapse button for the rest (read-only mode)
  • cover stays cover, dont show any code

2024-06-20 10_34_38-Journal of Digital History

2024-06-20 10_34_44-Journal of Digital History

2024-06-20 10_35_42-Thebe - Figma

Change name:

  • change data to "data / code"
  • delete 1, 2, 3? or what is meaning

Table of Contents: @danieleguido

  • left side like in Figma

2024-06-20 10_28_57-Thebe - Figma

  • design the status btn & error msg @biumiamy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants