fixed validation in create group api #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClawedCatalyst
requested changes
Oct 5, 2023
| @@ -29,6 +29,13 @@ def get_queryset(self): | |||
| return Groups.objects.filter(user=self.request.user.id) | |||
|
|
|||
| def post(self, request, *args, **kwargs): | |||
|
|
|||
| if not request.user.is_authenticated: | |||
There was a problem hiding this comment.
authentication is being checked above.
on line 22
permission_classes = [IsAuthenticated]
you have to validate if the authenticated user is the same user that is being passed in the json request of the api.
There was a problem hiding this comment.
ok then i will change it and again make the pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This PR fixes the validation in create group
Why was this change needed?
The change needed to ensure only the authenticated user can send the mail.
Fixes #9