Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming of classes #3

Open
ClawedCatalyst opened this issue Aug 17, 2023 · 8 comments · May be fixed by #20
Open

Fix naming of classes #3

ClawedCatalyst opened this issue Aug 17, 2023 · 8 comments · May be fixed by #20
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ClawedCatalyst
Copy link
Member

ClawedCatalyst commented Aug 17, 2023 •
edited
Loading

image

naming should be in camel case instead of snake case

ex :

in mailer/views.py

View_Group_Data should be ViewGroupData

and this should be followed for every class
@ClawedCatalyst ClawedCatalyst self-assigned this Aug 17, 2023
@ClawedCatalyst ClawedCatalyst added the enhancement New feature or request label Aug 17, 2023
@ClawedCatalyst ClawedCatalyst removed their assignment Oct 1, 2023
@ClawedCatalyst ClawedCatalyst added good first issue Good for newcomers hacktoberfest PR for Hacktoberfest labels Oct 1, 2023
@devaprog
Copy link
Contributor

devaprog commented Oct 2, 2023

I want to solve this issue myself, Can I involve in this?

@ClawedCatalyst
Copy link
Member Author

Yeah sure @devaprog ,
go for it

@devaprog
Copy link
Contributor

devaprog commented Oct 3, 2023

I changed the class names: snake case to camel case & checked: there is no break/error. but not tested, is there any specific, I need to verify before PR & need any test?

@ClawedCatalyst
Copy link
Member Author

cool lmk when you are done :) @devaprog

@grow-xd
Copy link

grow-xd commented Oct 4, 2023

if any problem occurs, can I take the issue

@kiranrokkam09
Copy link

I would like to contribute to this issue. Is anybody working with it?

@lakshay-saini-au8 lakshay-saini-au8 mentioned this issue Oct 6, 2023
Open
@lakshay-saini-au8
Copy link

@ClawedCatalyst Created the PR for this issue Please do Review.
Also Before merging please assign the issue to me

This was referenced Oct 6, 2023
Merged
Open
@ClawedCatalyst
Copy link
Member Author

Sorry @lakshay-saini-au8 actually I have assigned this issue to @devaprog and
he is working on this issue

@ClawedCatalyst ClawedCatalyst removed the hacktoberfest PR for Hacktoberfest label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Continuation of refactor: Renamed Snake_case class to CamelCase devaprog/BulkMailer-Backend
5 participants
@lakshay-saini-au8 @grow-xd @kiranrokkam09 @ClawedCatalyst @devaprog