Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Make storybookJS publicly available #286

Open
mejiaj opened this issue Aug 30, 2024 · 3 comments
Open

Enhancement: Make storybookJS publicly available #286

mejiaj opened this issue Aug 30, 2024 · 3 comments
Labels
enhancement New feature or request Storybook

Comments

@mejiaj
Copy link
Collaborator

mejiaj commented Aug 30, 2024

Make storybookJS build publicly available to share with non-technical stakeholders.
@mejiaj mejiaj added enhancement New feature or request Storybook labels Aug 30, 2024
@mejiaj
Copy link
Collaborator Author

mejiaj commented Oct 22, 2024

@mpbixal what do you think about bumping this issue up? It'd make our future designs more consistent and would give designers the ability to build off of existing work rather than starting from scratch every time.

Possible alternative is building/hosting on GH pages.

@mattsqd
Copy link
Collaborator

mattsqd commented Oct 22, 2024

Thanks @mejiaj , good idea. This was a lot of fun to work through.

mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Try to fix root for SB.
41c0e30
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Try an empty root.
dac219a
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Disable server side scripting, move into sub-dir inst…
587cfe9 
…ead of sub-domain.
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Allow storybook to build as if its in a sub dir.
af6a8a7
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Dont use passthrough for sb, instead set the index.
59e53c1
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Remove preceding slash for index.
0c97cc6
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Remove source operation. Allow node server to sleep. …
2d94d59 
…Remove npm install, it already happens from the build flavor. Try to change index to sb/.
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Moved commands and undid index change.
a7a279a
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: See if subdomain works.
5401094
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Subdomain worked, put back in sub-dir code commented …
8e46e81 
…out so it can be brought back if needed.
mattsqd added a commit that referenced this issue Oct 22, 2024
@mattsqd
BSD fixes #286: Missing npm from the front of run command.
5d42df6
mattsqd added a commit that referenced this issue Oct 25, 2024
@mattsqd
Merge pull request #317 from Bixal/feature/BSD-286-remote-storybook
eb06638 
BSD fixes #286: Add storybook an application in platform.sh.
@mattsqd
Copy link
Collaborator

mattsqd commented Oct 31, 2024

It turns out my approach to this, adding a second application, did not work when this was deployed to production. The new application caused us to go over our limit of CPU resources. I reverted that here https://github.com/Bixal/bixal-site-drupal/pull/326/files. I believe we should still be able to do this without needing a second application, I'll take another shot at this soon.

@mattsqd mattsqd reopened this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Storybook
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsqd @mejiaj