-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] partition_cut_mask says it has a width parameter but it doesn't #1415
Comments
This is just a documentation issue, right? The parameter w does not exist and needs to be removed from the docs. It isn't relevant to the cut mask. |
I think I expected to be able to scale my mask, hence the scale() mention. If the width parameter isn't supposed to be used for that, then my solution is proper and it's just a documentation issue |
But isn't the cut mask just the line between the two things? Why would you want to scale that? Scaling would make the gap non-uniform in thickness so I don't think that's correct. I think if you want a larger dovetail you increase cutsize and/or gap. Revar responded to this issue by trying to completely rewrite the partitioning code...but that project is evidently stalled, so I thought maybe I'd try to at least fix the docs. |
Here's the implementation I used: https://git.zyphon.com/will/doggie-door/src/branch/main/doggie-door.scad#L171 |
I think instead of scale you should have done:
which maintains a uniform thickness. |
PR fixes this by removing the extra parameter from the docs. |
Describe the bug
partition_cut_mask(l=1,w=1,h=1) is valid according to the documentation but isn't actually implemented in code;
w
isn't a parameter.Code To Reproduce Bug
Expected behavior
I can adjust all dimensions of my dovetail without resorting to scale()
The text was updated successfully, but these errors were encountered: