Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes can be None in proxy #85

Closed
ianturton opened this issue Jun 10, 2019 · 1 comment
Closed

Excludes can be None in proxy #85

ianturton opened this issue Jun 10, 2019 · 1 comment

Comments

@ianturton
Copy link
Contributor

In core/proxy.py:

26 excludes = settings.value("proxy/proxyExcludedUrls", "")
27 if hasattr(excludes, 'isNull') and excludes.isNull():
28 excludes = []
29 else:
30 excludes = excludes.split("|")

If excludes in None then line 30 throws an exception.
fix to:

26 excludes = settings.value("proxy/proxyExcludedUrls", "")
27 if not excludes or (hasattr(excludes, 'isNull') and excludes.isNull()):
28 excludes = []
29 else:
30 excludes = excludes.split("|")

Environment

QGIS version 3.6.3-Noosa QGIS code revision 0c5774c
Compiled against Qt 5.9.5 Running against Qt 5.9.5
Compiled against GDAL/OGR 2.2.3 Running against GDAL/OGR 2.2.3
Compiled against GEOS 3.6.2-CAPI-1.10.2 Running against GEOS 3.6.2-CAPI-1.10.2 4d2925d6
PostgreSQL Client Version 10.8 (Ubuntu 10.8-0ubuntu0.18.04.1) SpatiaLite Version 4.3.0a
QWT Version 6.1.3 QScintilla2 Version 2.10.2
PROJ.4 Version 493
@Guts
Copy link
Collaborator

Guts commented Dec 10, 2020

Anterior to the duplicated #88, but less documented.
Please follow up the new one.

@Guts Guts closed this as completed Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants