Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Have the possibility to decide the installation expiration window #51

Open
andrekiba opened this issue Feb 2, 2021 · 3 comments

Comments

@andrekiba
Copy link

andrekiba commented Feb 2, 2021

Is your feature request related to a problem? Please describe.
I still do not understand why you decided to reverse the default behavior (no expiration) but in this case we need I way to decide the expiration window (some apps are meant to be kiosks, they "never" restart...)

Describe the solution you'd like
Provide a way to pass a custom (longer) duration through the NotificationHubInstallationAdapter constructor.
Actually this constructor is private

Please tell me if I can help with a pr, the problem is the meaning of this project which is not clear to me.
Is it something official? As already asked do you plan to have a nuget package? In which way I can help?
Thanks @marstr

@marstr
Copy link
Member

marstr commented Feb 2, 2021

This is a valuable explanation of why you need more control over expiration dates. While expiration dates really help us at an operational level, I can start looking into an option for you. If nothing else, this could be a good cookbook addition.

@marstr
Copy link
Member

marstr commented Feb 3, 2021

Howdy @andrekiba,

There's a method called NotificationHub.BeginInstallationUpdate(). It's a public method, and under the covers it's what is used to alert us that we should look into updating an Installation for a myriad of reasons, but including that the installation is about to expire.

If you add a call to this method that happens periodically (say once a day), your installation will always be kept alive.

@andrekiba
Copy link
Author

ok @marstr thanks,
I try with a scheduled daily task to call this.
I'll keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants