[Skia] Fix RadialGradientBrush for non center origin #17925
+126
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gillibald
force-pushed
the
fixes/RadialGradientBrush
branch
from
c2379a0 to
29ee228
Compare
Gillibald
changed the title
Gillibald
force-pushed
the
fixes/RadialGradientBrush
branch
from
29ee228 to
90125e4
Compare
|
You can test this PR using the following package version. |
Gillibald
changed the title
Gillibald
added
bug
customer-priority
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR adjusts the Skia RadialGradientBrush not to reverse the order of gradient stops when the gradient isn't covering the full radius. Otherwise, the shader isn't working as expected.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues