[DotCom Launch]: Vitrum

[iamtakashi]

DotCom launch checklist

• Create demo site
• Create theme showcase
• Network activate
• Add theme to the curated list
• Verify theme in showcase
• Verify theme in onboarding

[iamtakashi]

@henriqueiamarino, I thought this is the best place to leave my notes to review before the dotcom launch.

• The height difference is a bit awkward. Have a look at this; if you subtract the thickness of the border from the padding, you can make both the same dimension.
• The contentSize is set to 900, which doesn't make sense. The width for posts seems to be 1051px, which is probably the best default content width.
• In templates/404.html, templates/archive.html, templates/index.html, templates/search.html, templates/single.html, there are strings that are not internationalised. Re-save the theme with CBT so that they become patterns.
• Remove unused patterns patterns/about.php, and patterns/hidden-404.php
• Change Tested up to: to 6.7 in readme.txt and style.css
• Change Requires PHP: to 7.0 in readme.txt and style.css
• Let's review the image credits to remove unnecessary links. Since the theme doesn't bundle any image, let's add credits for the two images we see in the screenshot.png
• Let's change the version to 1.4.0 in style.css
• Remove the following theme tags, entertainment, portfolio, block-patterns, custom-colors, custom-header, custom-menu, editor-style, full-width-template, template-editing, theme-options
• Add wide-blocks tag
• This comment is duplicated in style.css

/*
 * Font smoothing.
 * This is a niche setting that will not be available via Global Styles.
 * https://github.com/WordPress/gutenberg/issues/35934
 */

• There are several uses of numeric font sizes in the theme. We could make x-small for the blocks using 0.8rem and similar sizes. We should be able to use other presets existing in the theme for others with small differences.

[henriqueiamarino]

The issues are awaiting your review here (#8554), @iamtakashi.