From bfe0557f0b802d691d0d5c0e648677b8fca0a4c5 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Fri, 13 Sep 2024 10:53:50 +0930 Subject: [PATCH] topology: fix overzealous deprecation check in listpeerchannels. It's an output field (which we don't complain about), not an input field! Fixes: https://github.com/ElementsProject/lightning/issues/7652 Changelog-Fixed: Logging: removed bogus "**BROKEN** plugin-topology: DEPRECATED API USED: listchannels.include_private" message. Signed-off-by: Rusty Russell --- plugins/topology.c | 2 +- tests/test_plugin.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/plugins/topology.c b/plugins/topology.c index 8b9ad3d0a711..665072b2e9cb 100644 --- a/plugins/topology.c +++ b/plugins/topology.c @@ -394,7 +394,7 @@ static struct command_result *listpeerchannels_done(struct command *cmd, struct gossmap_localmods *mods; /* In deprecated mode, re-add private channels */ - if (command_deprecated_in_ok(cmd, "include_private", "v24.02", "v24.08")) { + if (command_deprecated_out_ok(cmd, "include_private", "v24.02", "v24.08")) { connected = local_connected(opts, buf, result); mods = gossmods_from_listpeerchannels(tmpctx, &local_id, buf, result, false, diff --git a/tests/test_plugin.py b/tests/test_plugin.py index 63e83f6f7292..1c527741f983 100644 --- a/tests/test_plugin.py +++ b/tests/test_plugin.py @@ -4417,7 +4417,6 @@ def test_sql_crash(node_factory, bitcoind): l1.rpc.sql(f"SELECT * FROM peerchannels;") -@pytest.mark.xfail(strict=True) def test_listchannels_broken_message(node_factory): """This gave a bogus BROKEN message with deprecated-apis enabled""" l1 = node_factory.get_node(options={'allow-deprecated-apis': True})