Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Effort #155

Closed
8 tasks done
lokka30 opened this issue Feb 17, 2022 · 8 comments
Closed
8 tasks done

Documentation Effort #155

lokka30 opened this issue Feb 17, 2022 · 8 comments
Assignees
Labels
core team task Task intended for the maintainers to complete, contributions not desired. priority: normal Normal priority status: confirmed Approved / validated type: documentation Changes to the documentation
Milestone

Comments

@lokka30
Copy link
Member

lokka30 commented Feb 17, 2022

Why?

Treasury's documentation could be considered relatively good at this point, however, since we use a concurrency system, it is more difficult to use. Therefore we need to provide very solid documentation if we have any hopes of gaining adoption in the community.


Things to do

Wiki

Cover all the updates since 1.0.0

Basically update the wiki with all the changes that occurred afterwards (2.0.0 included).

Add 'Getting Started' page - short and concise version to get started with Treasury.

  • Page created
  • Created draft
  • Refined content

The average developer probably doesn't want to read all the details about the economy API, rather, just want to know how to do these simple operations:

  • add maven repo
  • get the economy provider from the service registry
  • get/set balance, withdraw, deposit to player accounts
    • We will absolutely be showing CompletableFuture examples on this page. We should still touch on just the standard EconomySubscriber at the bottom of the page, but we must promote Futures over Subscribers for cleanliness and ease of use.
  • Although we must heavily recommend against doing so, we should show how developers can run the CompletableFutures synchronously in the case that it is unfeasible for them to use Treasury due to poorly designed code that lacks concurrency.

Thank you to AlonsoAliaga for suggesting this.

Javadocs

Javadocs must be improved as a whole. See #250.

@lokka30 lokka30 changed the title a Add (not replace!) simplified documentation Feb 17, 2022
@ArcanePlugins ArcanePlugins deleted a comment from MrNemo64 Feb 19, 2022
@lokka30 lokka30 self-assigned this Feb 19, 2022
@lokka30 lokka30 added priority: high High priority type: documentation Changes to the documentation labels Feb 19, 2022
@lokka30 lokka30 changed the title Add (not replace!) simplified documentation Documentation Effort Feb 19, 2022
@lokka30 lokka30 added the status: confirmed Approved / validated label Feb 19, 2022
@lokka30
Copy link
Member Author

lokka30 commented Mar 25, 2022

TODO: add constrictions to all methods, add documentation for using all methods with futures

@MrNemo64
Copy link
Contributor

Since the release of Java 18, code in the javadoc is a feature. Would it be possible to use it?
https://youtu.be/m2cVOYuVs1U?t=102

@lokka30
Copy link
Member Author

lokka30 commented Mar 25, 2022

Since the release of Java 18, code in the javadoc is a feature. Would it be possible to use it? https://youtu.be/m2cVOYuVs1U?t=102

Cool feature! I'm interested so long it doesn't cause any complications in the CI systems.

@lokka30 lokka30 added good first issue A great choice for new contributors to work on priority: normal Normal priority and removed priority: high High priority labels Nov 3, 2022
@lokka30 lokka30 added this to the v2.0.0 milestone Dec 12, 2022
@lokka30
Copy link
Member Author

lokka30 commented Jun 4, 2023

Status: Began work. Updated OP.

@lokka30
Copy link
Member Author

lokka30 commented Jun 13, 2023

Status: To speed up the release of V2, I'd prefer to just have the quickstart pages be the only barrier before we can push out v2 and have eyes on whether or not people think they'll want to adopt it.

@lokka30 lokka30 added core team task Task intended for the maintainers to complete, contributions not desired. and removed good first issue A great choice for new contributors to work on labels Jun 13, 2023
@lokka30
Copy link
Member Author

lokka30 commented Jun 24, 2023

Fully or mostly completed this quickstart page: https://github.com/ArcanePlugins/Treasury/wiki/Quickstart:-Economy-Consumer

@lokka30
Copy link
Member Author

lokka30 commented Jun 25, 2023

Written part of the Economy Provider quickstart guide.

Reformatted the sidebar of the Wiki.

Moved some of this issue's to-do list over to #280 since they aren't anywhere near as urgent as the quickstart guides.

@lokka30
Copy link
Member Author

lokka30 commented Jun 29, 2023

Wiki appears to be in a state suitable enough for launch.

@lokka30 lokka30 closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team task Task intended for the maintainers to complete, contributions not desired. priority: normal Normal priority status: confirmed Approved / validated type: documentation Changes to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants