-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid adding new proposer policy if there is no change #6
Comments
arhag
changed the title
IF: Avoid adding new proposer policy if there is no change
Avoid adding new proposer policy if there is no change
Apr 10, 2024
heifner
added a commit
that referenced
this issue
Apr 24, 2024
heifner
added a commit
that referenced
this issue
Apr 25, 2024
heifner
added a commit
that referenced
this issue
Apr 25, 2024
heifner
added a commit
that referenced
this issue
Apr 25, 2024
IF: Do not set new proposer policy unless different
heifner
added a commit
that referenced
this issue
Apr 26, 2024
heifner
added a commit
that referenced
this issue
Apr 30, 2024
heifner
added a commit
that referenced
this issue
Apr 30, 2024
heifner
added a commit
that referenced
this issue
May 1, 2024
heifner
added a commit
that referenced
this issue
May 1, 2024
heifner
added a commit
that referenced
this issue
May 1, 2024
heifner
added a commit
that referenced
this issue
May 2, 2024
heifner
added a commit
that referenced
this issue
May 2, 2024
heifner
added a commit
that referenced
this issue
May 2, 2024
heifner
added a commit
that referenced
this issue
May 2, 2024
IF: Update new proposer policy algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The host function should check to see if the policy to be proposed is different than the last proposal policy in the queue (not the currently active one). If it is the same, it should avoid actually adding the policy to the queue (it acts like a no-op).
The host function would uint32_t max as the version number if the proposed policy is not invalid. If it is invalid (e.g. empty producers in the policy) it would return -1; this is the only time is returns -1. This means that if the caller of the host function proposes a policy that is identical to the one it last proposed, the host function will still return successfully (not with a -1 return value).
The diff in the block extension is relative to the previous policy proposed and represented in a block extension (as a diff) in the history of the chain.
This is a change the protocol, so if we want to do it we need to get it done before rc1. But it also is not necessary to make this change to the protocol prior to release.
The text was updated successfully, but these errors were encountered: