Block from future is ignored

[heifner]

On the spring beta1 testnet, local node synced up:

info  2024-06-05T12:51:28.342 nodeos.be net_plugin.cpp:3902           process_signed_block ] block_validate_exception connection - 6: #4782125 4af601b35d70b371...: Block is from the future (3030007)
received a block from the future, ignoring it: 0048f82d4af601b35d70b371b28cb24dad93753400183c37f5023f70d586e68b

Sends handshake and then gets the block again and it applies it with no issue.

info  2024-06-05T12:51:33.477 nodeos.be controller.cpp:3454           log_applied          ] Received block 4af601b35d70b371... #4782125 @ 2024-06-05T12:51:35.000 signed by dumpsterfire [trxs: 0, lib: 4782120, net: 0, cpu: 1, elapsed: 341, time: 1169, latency: -1522 ms]

Seems we are a bit too aggressive about what we consider the future. Aggravated by my clock being skewed by about 3 seconds.

[heifner]

Current threshold is 7 seconds.

[bhazzard]

Scope this to just non-bp / non-finalizer. Allow unlimited blocks from the future. Leave the current limits for BP / Finalizer.

[heifner]

Speculative blocks currently use:

spring/plugins/producer_plugin/producer_plugin.cpp

Lines 2004 to 2009 in 4ebe18b

	block_timestamp_type producer_plugin_impl::calculate_pending_block_time() const {
	const chain::controller& chain = chain_plug->chain();
	const fc::time_point now = fc::time_point::now();
	const fc::time_point base = std::max<fc::time_point>(now, chain.head().block_time());
	return block_timestamp_type(base).next();
	}

Which looks at now. Need to modify that for speculative blocks to always use head_block_time.next() instead.