Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Say which BP produced the block when logging missing votes #226

Closed
matthewdarwin opened this issue Jun 3, 2024 · 2 comments · Fixed by #402
Closed

Say which BP produced the block when logging missing votes #226

matthewdarwin opened this issue Jun 3, 2024 · 2 comments · Fixed by #402
Assignees
@heifner
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Milestone
Savanna: Cusp

Comments

@matthewdarwin
Copy link

Say which BP produced the block when logging missing votes

nodeos    producer_plugin.cpp:658       log_missing_votes    ] Block 4495445:ec2383692a886794 has no votes from finalizers: ["eosphereiobp","spherespring"]
@arhag arhag mentioned this issue Jun 5, 2024
Closed
@bhazzard
Copy link

This would be useful for diagnostic purposes. Example Scenario: the majority of voters are in the west, and then a block producer in the east consistently produces blocks with too few votes.

This information in the logs would allow noticing that.

@bhazzard
Copy link

Per Kevin: likely trivial to add, could also be useful to add latency.

@bhazzard bhazzard added enhancement New feature or request 👍 lgtm and removed triage labels Jun 27, 2024
@heifner heifner self-assigned this Jul 25, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Jul 25, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Jul 25, 2024
@heifner heifner added this to the Savanna: Cusp milestone Jul 25, 2024
heifner added a commit that referenced this issue Jul 25, 2024
@heifner
GH-226 Add producer, timestamp, and latency to missing vote log output
a3955ce
@heifner heifner mentioned this issue Jul 25, 2024
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Jul 25, 2024
heifner added a commit that referenced this issue Jul 25, 2024
@heifner
Merge pull request #402 from AntelopeIO/GH-226-missing-vote-log
9e5b99d 
Add producer, timestamp, and latency to missing vote log output
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Savanna: Cusp
Development

Successfully merging a pull request may close this issue.

Add producer, timestamp, and latency to missing vote log output AntelopeIO/spring
4 participants
@bhazzard @heifner @matthewdarwin @enf-ci-bot